Separate weekly openApi-doc refresh and command-metadata refresh#3467
Open
ramsessanchez wants to merge 13 commits intomainfrom
Open
Separate weekly openApi-doc refresh and command-metadata refresh#3467ramsessanchez wants to merge 13 commits intomainfrom
ramsessanchez wants to merge 13 commits intomainfrom
Conversation
Contributor
MIchaelMainer
left a comment
MIchaelMainer
left a comment
There was a problem hiding this comment.
I'm curious how much this reduces the average generation run.
| type: string | ||
| - name: BuildAgent | ||
| displayName: Build Agent | ||
| - name: SkipForceRefresh |
Contributor
There was a problem hiding this comment.
Why are these removed?
| targetType: inline | ||
| script: | | ||
| git status | ||
| git branch $(ComputeBranch.WeeklyBranch) |
Contributor
There was a problem hiding this comment.
Is the task variable name optional for specifying an environment variable set from an ADO task? I haven't seen this before
| sdl: | ||
| binskim: | ||
| enabled: false | ||
| justificationForDisabling: "Binskim keeps on crashing and failing the weekly build pipeline. Disabling it for now because we are unable to publish the artifacts to internal feeds." |
Contributor
There was a problem hiding this comment.
Do we understand why it is failing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split Weekly generation pipeline into two separate pipelines, one to retrieve openApi updates and individually build the modules, and a second pipeline to generate the comandMetadata which requires all modules build on a single image.
The following yml files handle the following:
1.) downloading the most recent openApi docs
2.) determine which modules have been updated
3.) build the updated modules independently to validate openApi document correctness
4.) if all updated modules build successfully then a PR is created with the updated openApi documents.
Weekly-Generation.yml
Individual-Workload-Module.yml
The second will be triggered on merges to Dev and can also be triggered manually.
1.) All modules are built on a single image
2.) the commandMetadata is generated after all modules are built.
3.) successful completion of both results in a pull request into the Dev branch with an updated commandMetadata file.
command-metadata-refresh.yml
Note: The second pipeline is still in testing as we can't test the pipeline fully until we have it registered as one of our pipelines in devops and add the appropriate token.